Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support module documentation #10

Closed
pawamoy opened this issue Dec 5, 2019 · 5 comments
Closed

Support module documentation #10

pawamoy opened this issue Dec 5, 2019 · 5 comments

Comments

@pawamoy
Copy link

pawamoy commented Dec 5, 2019

Does it support module documentation?

@tomchristie
Copy link
Owner

Nope. I guess we might consider a pull request for it, but it's otherwise not a priority for me right now.

@pawamoy
Copy link
Author

pawamoy commented Dec 5, 2019

I'll try to open a PR later then 🙂 At first sight it seems like it would not be too complicated. The AutoDocProcessor.RE regexp is OK. I think import_from_string will need an update, as well as AutoDocProcessor.run to prevent trying to render a signature for a module.

@pawamoy
Copy link
Author

pawamoy commented Dec 22, 2019

I eventually wrote my own mkdocs plugin, so I will not send a PR here. Got inspiration from your work so thank you. I will make sure to credit you in the readme since I stole your get_params function 😛 (already credited in code itself).

@StephenBrown2
Copy link

Wow, that's a pretty great demo gif. It would be wonderful if the two projects could be combined, as I know httpx and other encode projects could certainly benefit from the extra easy docs.

@pawamoy
Copy link
Author

pawamoy commented Dec 23, 2019

Wow, that's a pretty great demo gif.

Thanks 😄

It would be wonderful if the two projects could be combined, as I know httpx and other encode projects could certainly benefit from the extra easy docs.

I don't think it will be possible, or easy, or if it makes sense to combine them, because I went ahead and implemented a lot of features (and planning more, with configuration options), so it would mean a lot of (re)write for mkautodoc to match up thoses feature.

However! My code is currently badly designed (it was on purpose, to iterate quickly and see what was possible), and ideally would be refactored as a plugin+extension combo, so mkdocstrings, which is a plugin only right now, would totally benefit from stealing more from mkautodoc. I also gladly accept contributions of course.

For more information on the immediate future of mkdocstrings, see the refactor issue and the related mkdocs issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants