Use flycheck-buffer-saved-p instead #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ;; only saved files will be checked by mix | ||
| (setq flycheck-check-syntax-automatically '(mode-enabled save)) | ||
| (add-to-list 'flycheck-checkers 'elixir-mix)) | ||
| (add-to-list 'flycheck-checkers 'elixir-mix) |
There was a problem hiding this comment.
Please don't remove flycheck-mix-setup. Apart from breaking existing configurations, it's also bad style—loading Emacs Lisp libraries should never have side effects, i.e. change options, etc…
There was a problem hiding this comment.
thanks, wasn't sure about that. I was following https://github.com/flycheck/flycheck-mercury/blob/master/flycheck-mercury.el#L222 which was probably not a good example 😄
There was a problem hiding this comment.
@aaronjensen No, indeed. It should also provide a setup function, imho.
aaronjensen
force-pushed
the
patch-2
branch
2 times, most recently
from
7038db4
to
3b29740
Compare
|
@tomekowal Will you review this PR? |
|
Thanks, looks great 👍 |
aaronjensen
added a commit
to aaronjensen/spacemacs
that referenced
this pull request
Sep 1, 2016
`flycheck-mix` now uses `flycheck-buffer-saved-p` so it is safe to flycheck on idle: tomekowal/flycheck-mix#2
TheBB
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Oct 17, 2016
`flycheck-mix` now uses `flycheck-buffer-saved-p` so it is safe to flycheck on idle: tomekowal/flycheck-mix#2
syl20bnr
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Oct 19, 2016
`flycheck-mix` now uses `flycheck-buffer-saved-p` so it is safe to flycheck on idle: tomekowal/flycheck-mix#2
george-miller
pushed a commit
to george-miller/spacemacs
that referenced
this pull request
Nov 14, 2016
`flycheck-mix` now uses `flycheck-buffer-saved-p` so it is safe to flycheck on idle: tomekowal/flycheck-mix#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
According to @lunaryorn, this is the typical way to ensure that the flychecker is only run on save.