Apply retcode=None to the whole Pipeline tree (ie. when >2 commands in pipeline) #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I've noticed, that current implementation does not allow to disable returncode verification for the whole Pipeline, eg. (netstat["-tnlp"] | grep[pid] | grep[port])(retcode = None) still fails at grep[pid]: nonzero returncode while (netstat["-tnlp"] | grep[pid])(retcode = None) works as expected Am I missing something? Thanks! :)
|
Thanks! I'll merge it and then write some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've noticed, that current implementation does not allow to disable returncode verification for the whole pipeline (Pipeline tree),
eg.
(netstat["-tnlp"] | grep[pid] | grep[port])(retcode = None)fails at grep[pid]: nonzero returncodewhile
(netstat["-tnlp"] | grep[pid])(retcode = None)works as expectedAm I missing something?
Thanks! :)