Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__getitem__ seperation #300

Merged
merged 3 commits into from
Dec 28, 2016
Merged

__getitem__ seperation #300

merged 3 commits into from
Dec 28, 2016

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Dec 3, 2016

Refactoring __getitem__ into a normal method that __getitem__ calls. Due to the odd tuple behavior of __getitem__, it is harder to use as an explicit method call than the other special methods. Was added in response to #296.

Should not affect any existing code, as it just adds an alternate way to call a command using method syntax.

@coveralls
Copy link

coveralls commented Dec 3, 2016

Coverage Status

Coverage increased (+0.009%) to 80.484% when pulling 552ea69 on getitem into b461732 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 80.484% when pulling 552ea69 on getitem into b461732 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 80.484% when pulling 552ea69 on getitem into b461732 on master.

@coveralls
Copy link

coveralls commented Dec 27, 2016

Coverage Status

Coverage increased (+0.003%) to 80.852% when pulling b432917 on getitem into 8333fc4 on master.

@henryiii henryiii merged commit 1441c5a into master Dec 28, 2016
@henryiii henryiii deleted the getitem branch December 28, 2016 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants