Towards pathlib.Path.mkdir compatibility #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the
mkdir
method of Plumbum's path classes (local & remote) more compatible withpathlib.Path.mkdir
by implementing the argumentsparents
andexist_ok
that are present in the latter. Themode
argument has also been added to the argument list to match the signature of pathlib's method and preserve backwards-compatibility once it is implemented in the future, but I haven't implemented it yet, because pathlib does some umask-voodoo that I'd have to look into in more detail. I might add it later.Should be backwards-compatible with earlier Plumbum
mkdir
behavior (which unfortunately required choosing defaults different from pathlib's, however) and of course comes with tests.