Pipe to logger - a convenience mixin for sending command output to a logger #454

koreno · 2019-07-04T22:22:12Z

No description provided.

coveralls · 2019-07-05T16:31:50Z

Coverage increased (+0.1%) to 82.523% when pulling eba972d on pipe-to-logger into 6d29382 on master.

We don't want to yield data from a proc that has already been determined as timed-out

koreno · 2019-07-15T07:13:41Z

Another very useful pattern, for your review @henryiii

koreno · 2019-07-24T12:22:37Z

let's put this and #455 and release 1.6.8?

koreno and others added 2 commits July 5, 2019 00:22

modifiers: added PipeToLoggerMixin

6b745b8

Added support for line timeout in popen.iter_lines

8bf41de

koreno requested a review from henryiii July 4, 2019 22:22

koreno force-pushed the pipe-to-logger branch from 18a8692 to 1a24378 Compare July 5, 2019 16:06

koreno force-pushed the pipe-to-logger branch 4 times, most recently from 2cc12b9 to 186593e Compare July 8, 2019 08:21

koreno force-pushed the pipe-to-logger branch 2 times, most recently from fcf6c62 to 643f919 Compare July 14, 2019 21:22

koreno added 4 commits July 15, 2019 09:41

added BY_TYPE mode for iter_lines; updated tests

2695dfd

update changelog

683db28

commands: check for proc timeout before yielding in iter_lines

33caba9

We don't want to yield data from a proc that has already been determined as timed-out

modifiers: fix PipeToLoggerMixin to support logbook as well

ed93823

koreno force-pushed the pipe-to-logger branch from 643f919 to ed93823 Compare July 15, 2019 06:42

Merge branch 'master' into pipe-to-logger

eba972d

koreno merged commit bc79df2 into master Aug 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pipe to logger - a convenience mixin for sending command output to a logger #454

Pipe to logger - a convenience mixin for sending command output to a logger #454

koreno commented Jul 4, 2019

coveralls commented Jul 5, 2019 •

edited

Loading

koreno commented Jul 15, 2019

koreno commented Jul 24, 2019

Pipe to logger - a convenience mixin for sending command output to a logger #454

Pipe to logger - a convenience mixin for sending command output to a logger #454

Conversation

koreno commented Jul 4, 2019

coveralls commented Jul 5, 2019 • edited Loading

koreno commented Jul 15, 2019

koreno commented Jul 24, 2019

coveralls commented Jul 5, 2019 •

edited

Loading