Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paths: make subscription work for composing paths #455

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

koreno
Copy link
Collaborator

@koreno koreno commented Jul 14, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 82.416% when pulling 1577d30 on path-subscription into 0b0efd3 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 82.416% when pulling 1577d30 on path-subscription into 0b0efd3 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 82.416% when pulling 1577d30 on path-subscription into 0b0efd3 on master.

@koreno
Copy link
Collaborator Author

koreno commented Jul 15, 2019

This is ready for you @henryiii, let me know what you think

@koreno
Copy link
Collaborator Author

koreno commented Jul 24, 2019

@henryiii - what do you say, can we merge this?
and what's the criteria for releasing a new version?

@henryiii
Copy link
Collaborator

henryiii commented Aug 1, 2019

Sorry for the delay. I wasn't completely sure about this, I would like to make a paths behave as close to pathlib as possible, having a many ways to do something can be confusing and adds extra maintenance.

@henryiii
Copy link
Collaborator

henryiii commented Aug 1, 2019

I don't think it's necessarily bad, but those were my concerns.

@koreno
Copy link
Collaborator Author

koreno commented Aug 1, 2019

Sorry for the delay. I wasn't completely sure about this, I would like to make a paths behave as close to pathlib as possible, having a many ways to do something can be confusing and adds extra maintenance.

I guess it takes a "merge" to get your attention... 😄
I hear your concern, I just find the original syntax extremely inconvenient and not useful. as for pathlib - the fact it doesn't inherit from str makes it pretty inconvenient when used with other functions... but its also good since it means that subscription isn't conflicting with some other behavior (Afaik).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants