made StdinDataRedirection compatible with modifiers writing to stdout #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. fixed:
Modifiers writing to stdout – e.g.:
FG
,TEE
,RETCODE(FG=True)
andTF(FG=True)
– invoke commands with the specificationstdin=None
.This is handled correctly by
BaseCommand
; however,StdinDataRedirection
misinterprets this as a further attempt to specify stdin (i.e. to
specify something rather than nothing).
This change brings
StdinDataRedirection
in line with its base class,ignoring
None
as well asPIPE
.(Though a technical detail, the class would also have failed any
invocation setting
stdin=PIPE
, along the lines of: "TypeError: gotmultiple values for keyword argument 'stdin'". The kwargs passed to the
wrapped command's
popen
are corrected as well.)resolves #604