Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made StdinDataRedirection compatible with modifiers writing to stdout #605

Merged
merged 2 commits into from
Jun 24, 2022

Commits on Jun 22, 2022

  1. made StdinDataRedirection compatible with modifiers writing to stdout

    _I.e._ fixed:
    
        (cat << "meow") & FG
    
    Modifiers writing to stdout -- _e.g._: FG, TEE, RETCODE(FG=True) and
    TF(FG=True) -- invoke commands with the specification `stdin=None`.
    This is handled correctly by BaseCommand; however, StdinDataRedirection
    misinterprets this as a further attempt to specify stdin (_i.e._ to
    specify _something_ rather than _nothing_).
    
    This change brings StdinDataRedirection in line with its base class,
    ignoring `None` as well as `PIPE`.
    
    (Though a technical detail, the class would also have failed any
    invocation setting `stdin=PIPE`, along the lines of: "TypeError: got
    multiple values for keyword argument 'stdin'". The kwargs passed to the
    wrapped command's `popen` are corrected as well.)
    
    resolves tomerfiliba#604
    jesteria committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    70dc4a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. style: run pre-commit

    Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
    henryiii committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ac15f1c View commit details
    Browse the repository at this point in the history