navigator key added

[xoltawn]

It is related to this issue:
#195
I sent a pull request earlier but it has conflicts with main branch. so I send another PR regarding that issue
(sorry for the delay)

[xoltawn]

you just need to add
navigatorKey: GlobalKey<NavigatorState>(),
to your
RoutemasterDelegate;
then you can access current navigator key using:
routeMaster.navigatorKey

[anthonysette]

This would be a great feature. I was reviewing your code, why did you import lib/app.dart? @tomgilder could you review this?

My use case would be in the situation where you want to send in-app notifications. These snack bars depend on the current context and as of now, it needs to be passed around to keep it up to date with the current page. In some situations, the context is not current and so we get an error looking up a deactivated widget. If we had access to the current context for any page it would be a lot simpler to build out a notification handler. And there are plenty of other use cases such as the one @xoltawn mentioned in his last PR.

Let's get this pushed through, this is a great addition to the package.

[xoltawn]

@anthonysette importing the file must be an accident. I'm gonna remove it and push again

[anthonysette]

That would be great! We need to get a reviewer in here to close the PR. Once the fix is up I will test it, but I love this idea!

[xoltawn]

@anthonysette I just don't understand. I run flutter test on my machine and all tests pass. how should I check for more errors?

[anthonysette]

@tomgilder Can we merge this? The community would benefit a lot from this!

[anthonysette]

I have tested and am currently using these changes in production. This PR is solid. There have been no issues.

[xoltawn]

@tomgilder Will this be merged?

[xoltawn]

@BazinC changes are made to solve the issues you mentioned

[tomgilder]

Hi @xoltawn @anthonysette I've added this a slightly different way in PR #262.

Providing a GlobalKey<NavigatorState> will give you access to the context and navigator:

final navigatorKey = GlobalKey<NavigatorState>();

final delegate = RoutemasterDelegate(
  navigatorKey: navigatorKey,
  routesBuilder: (_) => RouteMap(
    routes: {
      '/': (_) => const MaterialPageOne(),
      '/two': (_) => const MaterialPageTwo(),
    },
  ),
);

// Get the current context
final context = navigatorKey.currentContext!;

// Pop the navigator
navigatorKey.currentState!.pop();