Add dir=auto to usernames

app/controllers/traces_controller.rb

@@ -30,7 +30,7 @@ def index
              elsif current_user && current_user == target_user
                t ".my_traces"
              else
-               t ".public_traces_from", :user => target_user.display_name
+               t ".public_traces_from_html", :user => target_user.display_name
              end
 
     @title += t ".tagged_with", :tags => params[:tag] if params[:tag]

app/helpers/changesets_helper.rb

@@ -3,7 +3,7 @@ def changeset_user_link(changeset)
     if changeset.user.status == "deleted"
       t("users.no_such_user.deleted")
     elsif changeset.user.data_public?
-      link_to(changeset.user.display_name, user_path(changeset.user))
+      link_to(changeset.user.display_name, user_path(changeset.user), :dir => :auto)
     else
       t("browse.anonymous")
     end

app/helpers/issues_helper.rb

@@ -17,7 +17,7 @@ def reportable_title(reportable)
     when DiaryEntry
       reportable.title
     when User
-      reportable.display_name
+      tag.span(reportable.display_name, :dir => :auto)
     when DiaryComment
       I18n.t("issues.helper.reportable_title.diary_comment", :entry_title => reportable.diary_entry.title, :comment_id => reportable.id)
     when Note

app/helpers/note_helper.rb

@@ -20,7 +20,7 @@ def note_author(author, link_options = {})
     elsif author.status == "deleted"
       t("users.no_such_user.deleted")
     else
-      link_to h(author.display_name), link_options.merge(:controller => "/users", :action => "show", :display_name => author.display_name)
+      link_to author.display_name, link_options.merge(:controller => "/users", :action => "show", :display_name => author.display_name), :dir => :auto
     end
   end
 end

app/views/browse/changeset.html.erb

@@ -41,7 +41,7 @@
                   <%= t(".commented_by_html",
                         :when => friendly_date_ago(comment.created_at),
                         :exact_time => l(comment.created_at),
-                        :user => link_to(comment.author.display_name, user_path(comment.author))) %>
+                        :user => link_to(comment.author.display_name, user_path(comment.author), :dir => :auto)) %>
                   <% if current_user and current_user.moderator? %>
                     — <span class="action-button" data-comment-id="<%= comment.id %>" data-method="POST" data-url="<%= changeset_comment_hide_url(comment.id) %>"><%= t("javascripts.changesets.show.hide_comment") %></span>
                   <% end %>
@@ -54,7 +54,7 @@
                   <%= t(".hidden_commented_by_html",
                         :when => friendly_date_ago(comment.created_at),
                         :exact_time => l(comment.created_at),
-                        :user => link_to(comment.author.display_name, user_path(comment.author))) %>
+                        :user => link_to(comment.author.display_name, user_path(comment.author), :dir => :auto)) %>
                   — <span class="action-button text-muted" data-comment-id="<%= comment.id %>" data-method="POST" data-url="<%= changeset_comment_unhide_url(comment.id) %>"><%= t("javascripts.changesets.show.unhide_comment") %></span>
                 </small>
                 <div dir="auto"><%= comment.body.to_html %></div>
@@ -124,7 +124,7 @@
       &middot;
     <% end %>
     <%= user = (@prev_by_user || @next_by_user).user.display_name
-        link_to tag.bdi(user), :controller => "changesets", :action => "index", :display_name => user %>
+        link_to tag.bdi(user), { :controller => "changesets", :action => "index", :display_name => user }, :dir => :auto %>
     <% if @next_by_user %>
       &middot;
       <%= link_to "#{@next_by_user.id} >>", :id => @next_by_user.id %>

app/views/dashboards/_contact.html.erb

@@ -10,7 +10,7 @@
   </div>
   <div class="col">
     <p class='text-muted mb-0'>
-      <%= link_to contact.display_name, user_path(contact) %>
+      <%= link_to contact.display_name, user_path(contact), :dir => :auto %>
       <% if @user.home_lon and @user.home_lat and contact.home_lon and contact.home_lat %>
         <% distance = @user.distance(contact) %>
         <% if distance < 1 %>

app/views/dashboards/_popup.html.erb

@@ -4,6 +4,6 @@
   </div>
   <div class="col mx-1">
     <p><%= t(".#{type}") %></p>
-    <p><%= link_to popup.display_name, user_path(popup) %></p>
+    <p><%= link_to popup.display_name, user_path(popup), :dir => :auto %></p>
   </div>
 </div>

app/views/diary_entries/_diary_comment.html.erb

@@ -3,7 +3,7 @@
     <%= user_thumbnail diary_comment.user %>
   </div>
   <div class="col">
-    <p class="text-muted comment-heading" id="comment<%= diary_comment.id %>"><%= t(".comment_from_html", :link_user => (link_to diary_comment.user.display_name, user_path(diary_comment.user)), :comment_created_at => link_to(l(diary_comment.created_at, :format => :friendly), :anchor => "comment#{diary_comment.id}")) %>
+    <p class="text-muted comment-heading" id="comment<%= diary_comment.id %>"><%= t(".comment_from_html", :link_user => link_to(diary_comment.user.display_name, user_path(diary_comment.user), :dir => :auto), :comment_created_at => link_to(l(diary_comment.created_at, :format => :friendly), :anchor => "comment#{diary_comment.id}")) %>
       <% if current_user and diary_comment.user.id != current_user.id %>
         | <%= report_link(t(".report"), diary_comment) %>
       <% end %>

app/views/diary_entries/_diary_entry.html.erb

@@ -14,7 +14,7 @@
     <% end %>
 
     <small class='text-muted'>
-      <%= t(".posted_by_html", :link_user => (link_to diary_entry.user.display_name, user_path(diary_entry.user)), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to diary_entry.language.name, :controller => "diary_entries", :action => "index", :display_name => nil, :language => diary_entry.language_code)) %>
+      <%= t(".posted_by_html", :link_user => link_to(diary_entry.user.display_name, user_path(diary_entry.user), :dir => :auto), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to diary_entry.language.name, :controller => "diary_entries", :action => "index", :display_name => nil, :language => diary_entry.language_code)) %>
       <% if (l(diary_entry.updated_at, :format => :blog) != l(diary_entry.created_at, :format => :blog)) %>
         <%= t(".updated_at_html", :updated => l(diary_entry.updated_at, :format => :blog)) %>
       <% end %>

app/views/diary_entries/comments.html.erb

@@ -1,6 +1,6 @@
 <% content_for :heading do %>
-  <h1><%= t ".heading", :user => @user.display_name %></h1>
-  <p><%= t ".subheading_html", :user => link_to(@user.display_name, user_path(@user)) %></p>
+  <h1><%= t ".heading_html", :user => tag.span(@user.display_name, :dir => :auto) %></h1>
+  <p><%= t ".subheading_html", :user => link_to(@user.display_name, user_path(@user), :dir => :auto) %></p>
 <% end %>
 
 <% if @comments.empty? %>

app/views/diary_entries/show.html.erb

@@ -4,7 +4,7 @@
       <%= user_image @entry.user %>
     </div>
     <div class="col">
-      <h1><%= link_to t(".user_title", :user => @entry.user.display_name), :action => :index %></h1>
+      <h1><%= link_to t(".user_title_html", :user => tag.span(@entry.user.display_name, :dir => :auto)), :action => :index %></h1>
       <p><%= rss_link_to :action => :rss, :display_name => @entry.user.display_name %></p>
     </div>
   </div>

app/views/friendships/make_friend.html.erb

@@ -1,5 +1,5 @@
 <% content_for :heading do %>
-  <h1><%= t ".heading", :user => @new_friend.display_name %></h1>
+  <h1><%= t ".heading_html", :user => tag.span(@new_friend.display_name, :dir => :auto) %></h1>
 <% end %>
 
 <%= bootstrap_form_tag do |f| %>

app/views/friendships/remove_friend.html.erb

@@ -1,5 +1,5 @@
 <% content_for :heading do %>
-  <h1><%= t ".heading", :user => @friend.display_name %></h1>
+  <h1><%= t ".heading_html", :user => tag.span(@friend.display_name, :dir => :auto) %></h1>
 <% end %>
 
 <%= bootstrap_form_tag do |f| %>

app/views/issues/_comments.html.erb

@@ -6,7 +6,7 @@
       </div>
       <div class="col">
         <p class="text-muted mb-0">
-          <%= t ".comment_from_html", :user_link => link_to(comment.user.display_name, user_path(comment.user)),
+          <%= t ".comment_from_html", :user_link => link_to(comment.user.display_name, user_path(comment.user), :dir => :auto),
                                       :comment_created_at => l(comment.created_at.to_datetime, :format => :friendly) %>
         </p>
         <p dir="auto"><%= comment.body %></p>

app/views/issues/_reports.html.erb

@@ -6,7 +6,7 @@
     <div class="col">
       <p class="text-muted mb-0">
         <%= t ".reported_by_html", :category => report.category,
-                                   :user => link_to(report.user.display_name, user_path(report.user)),
+                                   :user => link_to(report.user.display_name, user_path(report.user), :dir => :auto),
                                    :updated_at => l(report.updated_at.to_datetime, :format => :friendly) %>
       </p>
       <p><%= report.details %></p>

app/views/issues/index.html.erb

@@ -32,7 +32,8 @@
                      options_for_select(@users.all.collect { |f| [f.display_name, f.id] } << [t(".not_updated"), "nil"], params[:last_updated_by]),
                      :include_blank => t(".select_last_updated_by"),
                      :data => { :behavior => "category_dropdown" },
-                     :class => "form-control custom-select" %>
+                     :class => "form-control custom-select",
+                     :dir => :auto %>
     </div>
     <div class="form-group col-md-auto">
       <%= submit_tag t(".search"), :name => nil, :class => "btn btn-primary" %>
@@ -59,10 +60,10 @@
           <td><%= t ".states.#{issue.status}" %></td>
           <td class="text-nowrap"><%= link_to t(".reports_count", :count => issue.reports_count), issue %></td>
           <td><%= link_to reportable_title(issue.reportable), reportable_url(issue.reportable) %></td>
-          <td><%= link_to issue.reported_user.display_name, user_path(issue.reported_user) if issue.reported_user %></td>
+          <td><%= link_to issue.reported_user.display_name, user_path(issue.reported_user), :dir => :auto if issue.reported_user %></td>
           <td>
             <% if issue.user_updated %>
-              <%= t ".last_updated_time_user_html", :user => link_to(issue.user_updated.display_name, user_path(issue.user_updated)),
+              <%= t ".last_updated_time_user_html", :user => link_to(issue.user_updated.display_name, user_path(issue.user_updated), :dir => :auto),
                                                     :time => time_ago_in_words(issue.updated_at, :scope => :"datetime.distance_in_words_ago"),
                                                     :title => l(issue.updated_at) %>
             <% else %>

app/views/issues/show.html.erb

@@ -6,8 +6,12 @@
     <%= @issue.assigned_role %>
     | <%= t ".reports", :count => @issue.reports.count %>
     | <%= t ".report_created_at", :datetime => l(@issue.created_at.to_datetime, :format => :friendly) %>
-    <%= " | #{t('.last_resolved_at', :datetime => l(@issue.resolved_at.to_datetime, :format => :friendly))}" if @issue.resolved_at? %>
-    <%= " | #{t('.last_updated_at', :datetime => l(@issue.updated_at.to_datetime, :format => :friendly), :displayname => @issue.user_updated.display_name)}" if @issue.user_updated %>
+    <% if @issue.resolved_at? -%>
+    | <%= t(".last_resolved_at", :datetime => l(@issue.resolved_at.to_datetime, :format => :friendly)) %>
+    <% end -%>
+    <% if @issue.user_updated -%>
+    | <%= t(".last_updated_at_html", :datetime => l(@issue.updated_at.to_datetime, :format => :friendly), :displayname => tag.span(@issue.user_updated.display_name, :dir => :auto)) %>
+    <% end -%>
   </small>
 </p>
 <p>

app/views/layouts/_header.html.erb

@@ -84,7 +84,7 @@
           <%= user_thumbnail_tiny(current_user, :width => 25, :height => 25, :class => "user_thumbnail_tiny rounded-sm") %>
           <%= render :partial => "layouts/inbox" %>
           <span class="user-button">
-            <span class='username'>
+            <span class='username' dir="auto">
               <%= current_user.display_name %>
             </span>
           </span>

app/views/messages/_message_summary.html.erb

@@ -1,5 +1,5 @@
 <tr id="inbox-<%= message_summary.id %>" class="inbox-row<%= "-unread" unless message_summary.message_read? %>">
-  <td class="inbox-sender"><%= link_to message_summary.sender.display_name, user_path(message_summary.sender) %></td>
+  <td class="inbox-sender" dir="auto"><%= link_to message_summary.sender.display_name, user_path(message_summary.sender) %></td>
   <td class="inbox-subject" dir="auto"><%= link_to message_summary.title, message_path(message_summary) %></td>
   <td class="inbox-sent"><%= l message_summary.sent_on, :format => :friendly %></td>
   <td class="inbox-mark-unread"><%= button_to t(".unread_button"), message_mark_path(message_summary, :mark => "unread"), :remote => true, :class => "btn btn-sm btn-primary" %></td>

app/views/messages/_sent_message_summary.html.erb

@@ -1,5 +1,5 @@
 <tr class="inbox-row">
-  <td class="inbox-sender"><%= link_to sent_message_summary.recipient.display_name, user_path(sent_message_summary.recipient) %></td>
+  <td class="inbox-sender" dir="auto"><%= link_to sent_message_summary.recipient.display_name, user_path(sent_message_summary.recipient) %></td>
   <td class="inbox-subject" dir="auto"><%= link_to sent_message_summary.title, message_path(sent_message_summary) %></td>
   <td class="inbox-sent"><%= l sent_message_summary.sent_on, :format => :friendly %></td>
   <td class="inbox-destroy"><%= button_to t(".destroy_button"), message_path(sent_message_summary, :referer => request.fullpath), :method => :delete, :remote => true, :class => "btn btn-sm btn-danger" %></td>

app/views/messages/new.html.erb

@@ -1,5 +1,5 @@
 <% content_for :heading do %>
-  <h1><%= t(".send_message_to_html", :name => link_to(@message.recipient.display_name, user_path(@message.recipient))) %></h1>
+  <h1><%= t(".send_message_to_html", :name => link_to(@message.recipient.display_name, user_path(@message.recipient), :dir => :auto)) %></h1>
 <% end %>
 
 <%= bootstrap_form_for @message do |f| %>

app/views/messages/show.html.erb

@@ -5,7 +5,7 @@
 <% if current_user == @message.recipient %>
   <div class='info-line clearfix'>
     <%= user_thumbnail_tiny @message.sender %>
-    <%= link_to @message.sender.display_name, user_path(@message.sender) %></td>
+    <%= link_to @message.sender.display_name, user_path(@message.sender), :dir => :auto %></td>
     <div class='right'>
       <%= l @message.sent_on, :format => :friendly %>
     </div>
@@ -22,7 +22,7 @@
 <% else %>
   <div class='info-line clearfix'>
     <%= user_thumbnail_tiny @message.recipient %>
-    <%= link_to @message.recipient.display_name, user_path(@message.recipient) %></td>
+    <%= link_to @message.recipient.display_name, user_path(@message.recipient), :dir => :auto %></td>
     <div class='right'>
       <%= l @message.sent_on, :format => :friendly %>
     </div>

app/views/notes/index.html.erb

@@ -1,6 +1,6 @@
 <% content_for :heading do %>
-  <h1><%= t ".heading", :user => @user.display_name %></h1>
-  <p><%= t ".subheading_html", :user => link_to(@user.display_name, user_path(@user)) %></p>
+  <h1><%= t ".heading_html", :user => tag.span(@user.display_name, :dir => :auto) %></h1>
+  <p><%= t ".subheading_html", :user => link_to(@user.display_name, user_path(@user), :dir => :auto) %></p>
 <% end %>
 
 <% if @notes.empty? %>

app/views/oauth/authorize.html.erb

@@ -2,7 +2,7 @@
   <h1><%= t ".title" %></h1>
 <% end %>
 
-<p><%= t(".request_access_html", :app_name => link_to(@token.client_application.name, @token.client_application.url), :user => link_to(current_user.display_name, user_path(current_user))) %></p>
+<p><%= t(".request_access_html", :app_name => link_to(@token.client_application.name, @token.client_application.url), :user => link_to(current_user.display_name, user_path(current_user), :dir => :auto)) %></p>
 
 <%= bootstrap_form_tag do |f| %>
   <%= f.hidden_field :oauth_token, :value => @token.token %>

app/views/passwords/reset_password.html.erb

@@ -1,5 +1,5 @@
 <% content_for :heading do %>
-  <h1><%= t ".heading", :user => current_user.display_name %></h1>
+  <h1><%= t ".heading_html", :user => tag.span(current_user.display_name, :dir => :auto) %></h1>
 <% end %>
 
 <%= bootstrap_form_for current_user, :url => { :action => "reset_password" }, :html => { :method => :post } do |f| %>

app/views/redactions/show.html.erb

@@ -5,7 +5,7 @@
 
 <p>
   <b><%= t ".user" %></b>
-  <%= link_to(@redaction.user.display_name, user_path(@redaction.user)) %>
+  <%= link_to(@redaction.user.display_name, user_path(@redaction.user), :dir => :auto) %>
 </p>
 <div class="richtext text-break">
   <b><%= t ".description" %></b>

app/views/traces/_description.html.erb

@@ -1,6 +1,6 @@
 <%= image_tag(url_for(:controller => :traces, :action => :icon, :id => description.id, :display_name => description.user.display_name)) %>
 <% if description.size -%>
-<%= t ".description_with_count", :count => description.size, :user => description.user.display_name %>
+<%= t ".description_with_count_html", :count => description.size, :user => tag.span(description.user.display_name, :dir => :auto) %>
 <% else -%>
-<%= t ".description_without_count", :user => description.user.display_name %>
+<%= t ".description_without_count_html", :user => tag.span(description.user.display_name, :dir => :auto) %>
 <% end -%>

app/views/traces/_trace.html.erb

@@ -32,7 +32,7 @@
       <span title="<%= trace.timestamp %>">
         <%= time_ago_in_words(trace.timestamp, :scope => :"datetime.distance_in_words_ago") %>
       </span>
-      <%= t ".by" %> <%= link_to trace.user.display_name, user_path(trace.user) %>
+      <%= t ".by" %> <%= link_to trace.user.display_name, user_path(trace.user), :dir => :auto %>
       <% if !trace.tags.empty? %>
         <%= t ".in" %>
         <%= safe_join(trace.tags.collect { |tag| link_to_tag tag.tag }, ", ") %>

app/views/traces/index.html.erb

@@ -37,7 +37,7 @@
         </li>
       <% end %>
       <li class="nav-item">
-        <%= link_to t(".public_traces_from", :user => @target_user&.display_name), { :action => "mine", :page => nil }, { :class => "nav-link active" } %>
+        <%= link_to t(".public_traces_from_html", :user => tag.span(@target_user.display_name, :dir => :auto)), { :action => "mine", :page => nil }, { :class => "nav-link active" } %>
       </li>
     <% end %>
 

app/views/traces/show.html.erb

@@ -36,7 +36,7 @@
   <% end %>
   <tr>
     <td><%= t ".owner" %></td>
-    <td><%= link_to @trace.user.display_name, user_path(@trace.user) %></td>
+    <td><%= link_to @trace.user.display_name, user_path(@trace.user), :dir => :auto %></td>
   </tr>
   <tr>
     <td><%= t ".description" %></td>

app/views/user_blocks/_block.html.erb

@@ -1,17 +1,17 @@
 <tr>
   <% if show_user_name %>
-  <td><%= link_to block.user.display_name, user_path(block.user) %></td>
+  <td><%= link_to block.user.display_name, user_path(block.user), :dir => :auto %></td>
   <% end %>
   <% if show_creator_name %>
-  <td><%= link_to block.creator.display_name, user_path(block.creator) %></td>
+  <td><%= link_to block.creator.display_name, user_path(block.creator), :dir => :auto %></td>
   <% end %>
   <td><%= h truncate(block.reason) %></td>
   <td><%= h block_status(block) %></td>
   <td>
     <% if block.revoker_id.nil? %>
       <%= t(".not_revoked") %>
     <% else %>
-      <%= link_to block.revoker.display_name, user_path(block.revoker) %>
+      <%= link_to block.revoker.display_name, user_path(block.revoker), :dir => :auto %>
     <% end %>
   </td>
   <td><%= link_to t(".show"), block %></td>

app/views/user_blocks/blocks_by.html.erb

@@ -1,10 +1,10 @@
-<% @title = t(".title", :name => @user.display_name) %>
+<% @title = t(".title_html", :name => tag.span(@user.display_name, :dir => :auto)) %>
 <% content_for :heading do %>
-  <h1><%= t(".heading_html", :name => link_to(@user.display_name, user_path(@user))) %></h1>
+  <h1><%= t(".heading_html", :name => link_to(@user.display_name, user_path(@user), :dir => :auto)) %></h1>
 <% end %>
 
 <% unless @user_blocks.empty? %>
 <%= render :partial => "blocks", :locals => { :show_revoke_link => can?(:revoke, UserBlock), :show_user_name => true, :show_creator_name => false } %>
 <% else %>
-<p><%= t ".empty", :name => @user.display_name %></p>
+<p><%= t ".empty_html", :name => tag.span(@user.display_name, :dir => :auto) %></p>
 <% end %>

app/views/user_blocks/blocks_on.html.erb

@@ -1,9 +1,9 @@
-<% @title = t(".title", :name => @user.display_name) %>
+<% @title = t(".title_html", :name => tag.span(@user.display_name, :dir => :auto)) %>
 <% content_for :heading do %>
-  <h1><%= t(".heading_html", :name => link_to(@user.display_name, user_path(@user))) %></h1>
+  <h1><%= t(".heading_html", :name => link_to(@user.display_name, user_path(@user), :dir => :auto)) %></h1>
 <% end %>
 <% unless @user_blocks.empty? %>
 <%= render :partial => "blocks", :locals => { :show_revoke_link => can?(:revoke, UserBlock), :show_user_name => false, :show_creator_name => true } %>
 <% else %>
-<p><%= t ".empty", :name => @user.display_name %></p>
+<p><%= t ".empty_html", :name => tag.span(@user.display_name, :dir => :auto) %></p>
 <% end %>