Improve code readability

tomhughes · Aug 19, 2016 · b72bc8b · b72bc8b
1 parent f00b624
commit b72bc8b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
@@ -349,9 +349,13 @@ def confirm_email
         @user.email = @user.new_email
         @user.new_email = nil
         @user.email_valid = true
-        changed = gravatar_enable(@user)
+        gravatar_enabled = gravatar_enable(@user)
         if @user.save
-          flash[:notice] = (t "user.confirm_email.success") + (changed ? " " + gravatar_status_message(@user) : "")
+          flash[:notice] = if gravatar_enabled
+                             t("user.confirm_email.success") + " " + gravatar_status_message(@user)
+                           else
+                             t("user.confirm_email.success")
+                           end
         else
           flash[:errors] = @user.errors
         end