Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed-label: to-be-closed #2

Open
tomj opened this issue Apr 4, 2019 · 3 comments
Open

proposed-label: to-be-closed #2

tomj opened this issue Apr 4, 2019 · 3 comments

Comments

@tomj
Copy link
Owner

tomj commented Apr 4, 2019

EDIT: this referenced 2648 in the upstream but I've pulled the link out for now - it was mostly just a POC, but note that in the forum below it has been suggested the issue be closed.

https://community.signalusers.org/t/beta-feedback-for-the-upcoming-ios-2-38-release/6980/29?u=tomjtomj

@tomj
Copy link
Owner Author

tomj commented Apr 4, 2019

also as @five-c-d pointed out (pasting from the previously deleted issue):

Meta-discussion of this tomj/Signal-iOS/issues repo, is here: https://community.signalusers.org/t/getting-to-0-github-issues-in-signal-ios/7112

Specifically about ios#2648 however, it was listed in the signalUsers thread linked up above, as possibly ready to be closed. But to be sure it should be closed, we need somebody that is running iOS v8 still, to actually test the behavior on one of the impacted devices.

On IOS 8,
tested with Iphone 5 and 6,
signal4ios v2.17.1 crashes
when attaching images from locally stored photo gallery

Open contact
Tap paperclip to attach image
Select image
Tap Green send button
signal4ios crashes

Can somebody with iPhone 6or5, running the latest updates to iOS v8 but not running iOS-later-than-v8-yet, please install signal4ios v2.36 or v2.37 or v2.38 or something like that, run through the steps listed up above, and then post a debuglog? If there are no weird errors, and no crash of course, then we can propose-to-be-closed. But I think we want to verify that it can be closed, because the bug no longer manifests, before we link over.

@five-c-d
Copy link

five-c-d commented Apr 4, 2019

Meta comment, about the overall problem we are trying to solve here: These projects claim to be able to migrate an issue-list from point A to point B, maybe use one of them? Not sure if they will KEEP the issue-lists sync'd up however, which is a tougher problem! https://github.com/gatewayapps/kamino and also https://github.com/google/github-issue-mover , never used them just popped up in a quick bit of googling using duckduckgo.com

p.s. Also potentially interesting, the ability to download an issue-list to a laptop, https://github.com/jlord/offline-issues

@tomj
Copy link
Owner Author

tomj commented Apr 4, 2019

Thanks for the thoughts @five-c-d :) For now I'm just thinking to keep it super lightweight (ie: lazy). I'd actually bet 20c that GH are working on something to allow non-privileged contributors to suggest a label for a repo anyway (some of their team have been chatting over at this one: isaacs/github#148 (comment)), so if we 🤞 then perhaps it will be implemented natively soon 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants