Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add command-line argument "version" in test-runner #4

Closed
wants to merge 1 commit into from

Conversation

amanbh
Copy link

@amanbh amanbh commented Jun 24, 2020

Tests for multiple versions may be kept as subdirectories under the tests directory. This PR adds support to select a target version to test against by specifying the --version argument. The default value is the latest version.

This commit should be compatible with #3

@pradyunsg
Copy link
Member

I don't think we should do this -- instead, the compliance test suite should only target a single version of the TOML spec, and get released alongside (possibly with bugfixes).

@eksortso
Copy link

I'm inclined to agree, @pradunsg. A tagged branch of the compliance project can be kept for tagged versions of TOML, and new developments can be matched with merged-in tests downstream. No need to maintain all versions at once.

@pradyunsg pradyunsg closed this Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants