Dotted keys #505
Merged
Dotted keys #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
force-pushed
the
dotted-keys
branch
from
ea1d744
to
ca1d406
Compare
pradyunsg
commented
Nov 25, 2017
README.md
Outdated
| "color": "orange", | ||
| "shape": "round" | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this needs a line talking about whitespace and a section about when it's invalid.
@mojombo Something came up just now so I'm probably gonna be AWOL so, I'm cool with you taking this into your own hands if you want. :)
|
Ping @mojombo! :) |
|
Ping 2.0 @mojombo! 😬 |
|
Ping 3.0! |
|
Looks great. I'm merging this as-is, but we should think about being more specific about when tables are closed, per the discussion in #499. We can continue the discussion there. |
5 tasks
pradyunsg
added a commit
to pradyunsg/toml
that referenced
this pull request
May 11, 2018
toml-lang#505 wasn't super comprehensive with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #499
This will probably conflict with #500 since this also adds a "Keys" section.