Simplify inline-table ABNF definition #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
reviewed
Aug 20, 2018
| @@ -212,14 +212,13 @@ std-table-close = ws %x5D ; ] Right square bracket | |||
|
|
|||
| ;; Inline Table | |||
|
|
|||
| inline-table = inline-table-open inline-table-keyvals inline-table-close | |||
| inline-table = inline-table-open [ inline-table-keyvals ] inline-table-close | |||
There was a problem hiding this comment.
This change means that at least one key/value pair is required - the old way of expressing it allowed for "empty" tables.
There was a problem hiding this comment.
@bitwalker New way allows tables that do not have inline-table-keyvals at all. Is it not the same as "empty tables"?
There was a problem hiding this comment.
Ah, yep, you're right, I was looking at the old definitions of inline-table-* and forgot about the [] around inline-table-keyvals up here.
pradyunsg
approved these changes
Aug 21, 2018
|
Thanks for this PR @swissr! This is definitely an improvement over how it is currently. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100 % sure but I don't see a reason not to use optional directly in the 'inline-table' definition.