Do not allow surrogate code points in ABNF #619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a suggestion than a request.
I noticed that the current ABNF grammar allows UTF-16 surrogate code points (0xD800 - 0xDFFF) in strings and comments. This seems inconsistent, because it is invalid to insert these code points via escape sequences (e.g. \uD800).
This commit excludes the surrogate range. Because this affects five separate rules, I added a reusable rule
non-ascii
, to reduce redundancy.