-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re #571, allow raw tabs in basic and MLB strings #627
Conversation
This may take some investigation in case some parsers are doing this already, but perhaps this feature could be deferred until after the release of TOML 1.0? |
Yea, I don't see this as being super critical for 1.0 tbh. It's probably a good idea but be super conservative logic applies here. |
BTW, thanks for the ping on this; I'd completely forgotten about this PR. |
I oppose the delay. The problem stated in #571 is that the TOML spec is currently contradictory. The written spec says:
Which, according to the common understanding of whitespace, allows tabs. But another sentence in the spec forbids tabs, and the ABNF forbids them as well. TOML 1.0 should not be ambiguous, hence this PR must be merged (or the ambiguity must be resolved in another way) before TOML 1.0 can be released. |
Also I just noted that the written spec currently seems to forbid line breaks within multi-line basic strings (they are within the forbidden range), which is of course silly. I added an inline comment to the PR on how this can be resolved. This makes it all the more urgent to fix this (properly) before 1.0 is released. |
@ChristianSi consider me convinced. |
Include tab, with all of wschar, in basic-unescaped Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
Include tabs, and all of wschar, in ml-basic-unescaped Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
Thanks for reminding me. I'd forgotten that! |
In response to #571, these changes permit the horizontal tab character to be used in both basic strings and multi-line basic strings.