Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re #571, allow raw tabs in basic and MLB strings #627

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Re #571, allow raw tabs in basic and MLB strings #627

merged 4 commits into from
Jul 19, 2019

Conversation

eksortso
Copy link
Contributor

In response to #571, these changes permit the horizontal tab character to be used in both basic strings and multi-line basic strings.

@pradyunsg pradyunsg added this to Need to look at in TOML 1.0 Jun 11, 2019
@eksortso
Copy link
Contributor Author

This may take some investigation in case some parsers are doing this already, but perhaps this feature could be deferred until after the release of TOML 1.0?

@pradyunsg
Copy link
Member

Yea, I don't see this as being super critical for 1.0 tbh. It's probably a good idea but be super conservative logic applies here.

@pradyunsg pradyunsg removed this from Need to look at in TOML 1.0 Jul 17, 2019
@pradyunsg
Copy link
Member

BTW, thanks for the ping on this; I'd completely forgotten about this PR.

@ChristianSi
Copy link
Contributor

I oppose the delay. The problem stated in #571 is that the TOML spec is currently contradictory. The written spec says:

All other whitespace and newline characters remain intact.

Which, according to the common understanding of whitespace, allows tabs. But another sentence in the spec forbids tabs, and the ABNF forbids them as well. TOML 1.0 should not be ambiguous, hence this PR must be merged (or the ambiguity must be resolved in another way) before TOML 1.0 can be released.

README.md Outdated Show resolved Hide resolved
@ChristianSi
Copy link
Contributor

Also I just noted that the written spec currently seems to forbid line breaks within multi-line basic strings (they are within the forbidden range), which is of course silly. I added an inline comment to the PR on how this can be resolved.

This makes it all the more urgent to fix this (properly) before 1.0 is released.

@pradyunsg
Copy link
Member

@ChristianSi consider me convinced.

toml.abnf Outdated Show resolved Hide resolved
toml.abnf Outdated Show resolved Hide resolved
eksortso and others added 3 commits July 18, 2019 19:21
Include tab, with all of wschar, in basic-unescaped

Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
Include tabs, and all of wschar, in ml-basic-unescaped

Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
@eksortso
Copy link
Contributor Author

I oppose the delay. The problem stated in #571 is that the TOML spec is currently contradictory.

Thanks for reminding me. I'd forgotten that!

@pradyunsg pradyunsg merged commit 4d3d289 into toml-lang:master Jul 19, 2019
@pradyunsg pradyunsg added this to Done in TOML 1.0 via automation Jul 19, 2019
@eksortso eksortso deleted the i571-allow-raw-tabs branch July 20, 2019 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants