-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: highlighting is lost when colorscheme is changed #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New vim restores default highlight links, but fails to do it when there is no default link in the first place. Without this fix, vim-exchange looses highlighting after `:colorscheme ...` Relates to vim/vim#6970
Did you verify that this fixes the issue? It seems that the line you're adding is already being called at startup: vim-exchange/plugin/exchange.vim Lines 335 to 339 in e797a21
vim-exchange/plugin/exchange.vim Lines 232 to 239 in e797a21
|
Sure I did. Note default added. |
Yep, I see it now |
tommcdo
reviewed
Dec 16, 2020
Co-authored-by: Tom McDonald <tommcdo@gmail.com>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New vim restores default highlight links, but fails to do it when there is no default link in the first place.
Without this fix, vim-exchange looses highlighting after
:colorscheme ...
Relates to vim/vim#6970