Persist highlighting on color scheme change #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well-written Vim color schemes run the command :highlight clear to remove the highlight groups set by a previous color scheme. Unfortunately, this also removes the internal highlight group set by vim-exchange, effectively disabling vim-exchange's highlighting, and running :XchangeHighlightToggle does not reenable the plugin's highlighting. In this commit, this is fixed by adding an autocmd to link the _exchange_region highlight group back to ExchangeRegion when the color scheme is changed and the highlighting is enabled.
jchros
force-pushed
the
persist-hl-on-cs-change
branch
from
a9014d0
to
310e841
Compare
|
I hadn't had time to look into this in-depth, but I'm wondering if #53 addresses the issue? |
I just tried it (on Vim 8.2.2127) and it does fix the issue; thanks for replying! |
|
I am reopening this pull request because I've noticed that #53 introduces the opposite problem; when the highlighting is turned off, changing the color scheme turns it back on, as demonstrated in the video below: test1.movThe |
New vim restores default highlight links, but fails to do it when there is no default link in the first place. Without this fix, vim-exchange looses highlighting after `:colorscheme ...` Relates to vim/vim#6970
Co-authored-by: Tom McDonald <tommcdo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well-written Vim color schemes run the command
:highlight clearto remove the highlight groups set by a previous color scheme. Unfortunately, this also removes the internal highlight group set by vim-exchange, effectively disabling vim-exchange's highlighting, and running:XchangeHighlightToggledoes not reenable the plugin's highlighting, as demonstrated in the asciinema below:In this pull request, this is fixed by adding an
autocmdto link the_exchange_regionhighlight group back toExchangeRegionwhen the colorscheme is changed and the highlighting is enabled.Alternatives considered
Toggle highlighting twice
I have rejected this approach for 2 reasons: