added option to save log in the hdf raw data file plus changes to build on OSX/python3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgursoy
reviewed
Jan 14, 2020
| def blocked_view(proj, theta, params): | ||
| log.info(" *** correcting for blocked view data collection") | ||
| if params.blocked_views: | ||
| log.warning(' *** *** ON') |
There was a problem hiding this comment.
For global (and local) logging: https://stackoverflow.com/questions/7621897/python-logging-module-globally
There was a problem hiding this comment.
I think I am already using a global logger. This is defined in log.py.
There was a problem hiding this comment.
ah you mean having tomopy and tomopy-cli using the same logging?
decarlof
changed the title
Closed
decarlof
added a commit
that referenced
this pull request
Feb 12, 2020
aps-7bm
pushed a commit
to aps-7bm/tomopy-cli
that referenced
this pull request
Oct 29, 2020
changes to build on OSX/python3
aps-7bm
pushed a commit
to aps-7bm/tomopy-cli
that referenced
this pull request
Oct 29, 2020
decarlof
pushed a commit
that referenced
this pull request
Jan 4, 2021
decarlof
added a commit
that referenced
this pull request
Jan 25, 2021
decarlof
added a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aps-7bm needed to touch beamhardening.py to handle file path/name correctly also under MacOSX/python3.