Allow threads to specify code to run on the main thread #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we want to run code on the main thread instead of in the multiprocessing thread. For example, when using CUDA functions in ASTRA, all cuda code has to be run on the main thread. Currently, this has to be specified by the user by setting ncore=1. If you forget to specify this, cuda errors occur, and worse, the user has to kill the python process (ctrl+c and such do not work). This happens to me a lot, for example when switching from CPU to GPU ASTRA methods, and forgetting to specify ncore=1. This commit adds a shared Queue to the multiprocessing code, where threads can put things in that have to be run by the main thread. After all threads join, the main thread clears the queue by running all code in it. The commit also updates the ASTRA wrapper to use the queue when using CUDA functions of ASTRA. Therefore, ASTRA CUDA code always runs on the main thread, even when running on multiple cores, and no errors occur when forgetting to specify ncore=1.
dgursoy
added a commit
that referenced
this pull request
Aug 3, 2015
Allow threads to specify code to run on the main thread
carterbox
pushed a commit
that referenced
this pull request
Sep 16, 2018
Allow threads to specify code to run on the main thread Former-commit-id: 23f5942
carterbox
pushed a commit
that referenced
this pull request
Sep 16, 2018
Allow threads to specify code to run on the main thread Former-commit-id: 23f5942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we want to run code on the main thread
instead of in the multiprocessing thread. For example, when
using CUDA functions in ASTRA, all cuda code has to be run
on the main thread. Currently, this has to be specified by the
user by setting ncore=1. If you forget to specify this, cuda
errors occur, and worse, the user has to kill the python process
(ctrl+c and such do not work). This happens to me a lot, for example
when switching from CPU to GPU ASTRA methods, and forgetting to specify
ncore=1.
This commit adds a shared Queue to the multiprocessing code, where
threads can put things in that have to be run by the main thread. After
all threads join, the main thread clears the queue by running all code
in it. The commit also updates the ASTRA wrapper to use the queue when
using CUDA functions of ASTRA. Therefore, ASTRA CUDA code always runs
on the main thread, even when running on multiple cores, and no errors
occur when forgetting to specify ncore=1.