Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ring removal methods. Update docs style #386

Closed
wants to merge 9 commits into from

Conversation

nghia-vo
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 22, 2019

Coverage Status

Coverage decreased (-2.9%) to 54.644% when pulling d20af15 on nghia-vo:master into 2fe8472 on tomopy:master.

@nghia-vo
Copy link
Contributor Author

nghia-vo commented Feb 15, 2019

Is there any chance to merge this PR? There're rooms for improving coding style and debugging, but these algorithms are ready to be used. They give users more choices to deal with challenging ring artifacts.

@carterbox
Copy link
Member

@nghia-vo, thanks for your patience. @dgursoy was reviewing your original pull request, but then the holidays and some severe weather disrupted our work here in Chicagoland. I'll remind him about this today.

@carterbox
Copy link
Member

@nghia-vo This pull request is actually the same as #380, right? You actually don't need to open a new pull request when you make changes. You can just update the old one. Actually, it's probably better if we re-open the old one because all of Doga's comments are there. I'm going to try and do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants