Impl fmt::Write for AsciiString, and add tests #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomprogrammer
approved these changes
Feb 9, 2017
| @@ -466,6 +466,20 @@ impl fmt::Debug for AsciiString { | |||
| } | |||
| } | |||
|
|
|||
| impl fmt::Write for AsciiString { | |||
There was a problem hiding this comment.
I'll add some documentation that fmt::Write methods "[do] not support transmission of an error other than that an error occurred." (from std::fmt::Error). This is just to remind users of this API how to handle errors correctly.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented for std::String as well