Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s:ProcessSign does not handle new sign output #83

Open
blueyed opened this issue Jun 3, 2019 · 0 comments · May be fixed by #84
Open

s:ProcessSign does not handle new sign output #83

blueyed opened this issue Jun 3, 2019 · 0 comments · May be fixed by #84

Comments

@blueyed
Copy link
Contributor

blueyed commented Jun 3, 2019

Code ref:

quickfixsigns_vim/plugin/quickfixsigns.vim

Line 875 in 653cf16

let m = matchlist(a:sign, '^\s\+\S\+=\(\d\+\)\s\+\S\+=\(\d\+\)\s\+\S\+=\(\S\+\)\s*$')

Example sign-place output:

['--- Signs ---', 'Signs for foo:', '    line=99  id=3000  name=GitGutterLineModified  priority=10', '    line=100  id=3001  name=GitGutterLineAdded  priority=10' …

It should probably use the new sign_getplaced() there.
blueyed added a commit to blueyed/quickfixsigns_vim that referenced this issue Jun 3, 2019
@blueyed
QuickfixsignsListBufferSigns: use sign_getplaced
ee0723f 
TODO: does not set/have the "sign" attribute (easily), only used with
AssertUniqueSigns, where it could be removed/replaced - maybe only for
the new method / if missing then?!

Fixes tomtom#83.
@blueyed blueyed linked a pull request Jun 3, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QuickfixsignsListBufferSigns: use sign_getplaced blueyed/quickfixsigns_vim
1 participant
@blueyed