Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickfixsignsListBufferSigns: use sign_getplaced #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions autoload/quickfixsigns.vim
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ function! quickfixsigns#AssertUniqueSigns(bufnr, bufsigns) "{{{3
for bsign in a:bufsigns
let key = printf("%s|%s", bsign.lnum, bsign.name)
if has_key(dict, key)
" XXX: only usage of "sign.sign"
echom ("QuickFixSigns AssertUniqueSigns: duplicate bufnr=". a:bufnr .":") bsign.sign
else
let dict[key] = 1
Expand Down
13 changes: 13 additions & 0 deletions plugin/quickfixsigns.vim
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,19 @@ function! QuickfixsignsListBufferSigns(bufnr) "{{{3
if a:bufnr == -1
return []
endif

if exists('*sign_getplaced')
let r = []
for sign in sign_getplaced(a:bufnr)[0].signs
call add(r, {
\ 'lnum': sign.lnum,
\ 'id': sign.id,
\ 'name': sign.name,
\ })
endfor
return r
endif

let signss = s:Redir('sign place buffer='. a:bufnr)
if exists('signss')
let signs = split(signss, '\n')
Expand Down