Diagnostics rework #754
Merged
Diagnostics rework #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/diagnostics.py
Outdated
| self.invoke_each(lambda w: w.begin()) | ||
|
|
||
| if diagnostics_by_file is not None: | ||
| if diagnostics_by_file: |
There was a problem hiding this comment.
Why the double if for diagnostics_by_file? :-)
There was a problem hiding this comment.
Good catch, should have left a TODO there. The old update_diagnostics_panel had both checks and did nothing at all if diagnostics_by_file was None - I think that case can't happen anymore, so I'll remove the check!
|
Since this PR is a "rework" of diagnostics, would you consider adding unicode symbols, as such: |
|
@AmjadHD this PR is more about refactoring code instead of UI polish - if we can do something that looks good in all fonts then I'd like to see an example. |
Removes a use of global_events. Encapsulate state instead of storing it on the module.
Cursor listener should include from entire line Filter on lsp range/point instead of sublime position Also set status on active view
Thought about implementing F8 toggle a-la-VSCode, but can do that later.
tomv564
force-pushed
the
diagnostics-rework
branch
from
cc9665e
to
b10d054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Show diagnostics panel after saving" investigation (#748) showed the functionality could be "tacked" on, but would work better if components were set up in proper relations instead of querying global state.
In this PR, a DiagnosticsPresenter is introduced which gets access to DocumentHandler's events.
Clean ups:
show_diagnostics_phantomsfeature (as discussed in Remove show_view_status setting? #722)Desired fixes:
Stop using global_events for pushing diagnostics updates to ui
Remove duplication of looping logic over diagnostics after an update:
update_diagnostics_in_status_bar,update_diagnostics_panel,window_has_relevant_diagnostics,update_view_diagnostics(trying a strategy to update many things in a single walk through)Remove duplication querying diagnostics at a point:
point_diagnostics_by_configvsget_line_diagnostics(perhaps share a cache if cursor listener and bulb listener both want diagnostics?)Try to remove the need for
get_window_diagnostics/get_view_diagnostics- it should be easy to access the DiagnosticsStorage, and it should expose useful functions for accessing/filtering data.