Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass card shows wrong text direction #13

Closed
dhover opened this issue Aug 12, 2020 · 6 comments · Fixed by #16
Closed

Compass card shows wrong text direction #13

dhover opened this issue Aug 12, 2020 · 6 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@dhover
Copy link

dhover commented Aug 12, 2020

The degrees shown are ok but the wind direction (text) isn't. There is an offset needed of about 11!

The following table should be used if whole degrees are being used.

  • N value <=11
  • NNE 11 < value <=33
  • NE 33 < value <=56
  • ENE 56 < value <=78
  • E 78 < value <=101
  • ESE 101 < value <=123
  • SE 123 < value <=146
  • SSE 146 < value <=168
  • S 168 < value <=191
  • SSW 191 < value <=213
  • SW 213 < value <=236
  • WSW 236 < value <=258
  • W 258 < value <=281
  • WNW 281 < value <=303
  • NW 303 < value <=326
  • NNW 326 < value <=348
  • N 348 < value
@dhover dhover added the bug Something isn't working label Aug 12, 2020
@tomvanswam
Copy link
Owner

What version are you using? Should be fixed in v0.0.5 (see #10)

@dhover
Copy link
Author

dhover commented Aug 12, 2020

Hi Tom,

Im using version 0.0.5.

@tomvanswam
Copy link
Owner

Ok, strange, have to ask (stupid question, I know) have you force reloaded the page with the card on it, after updating the card? (Ctrl+F5).
Your values are identical to the ones mentioned in #10 and I implemented those (or atleast tried to) and tested it which seemed ok to me.

At the moment my development environment is failing me so might take me a bit to get a look.

@tomvanswam tomvanswam self-assigned this Aug 12, 2020
@dhover
Copy link
Author

dhover commented Aug 12, 2020

Now it is working. I don't know why. Maybe there was a cache in between.
I checked all the boundary values and it is perfect now!

@dhover
Copy link
Author

dhover commented Aug 12, 2020

One suggestion to make it even beter: The entities are not sorted. So it it difficult to find the right one!

@tomvanswam
Copy link
Owner

Good idea, honestly i thought the list would be auto sorted. I'll check if i can sort it myself.
Thanks for letting me know it works now. I'll close the issue then.

@tomvanswam tomvanswam removed their assignment Aug 12, 2020
tomvanswam added a commit that referenced this issue Aug 14, 2020
Localized editor headings
Full width entity picker in editor
Indicator default color: theme accent color (color picking coming soon!)
Remove more css bloat
@tomvanswam tomvanswam linked a pull request Aug 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants