Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong abbreviations #10

Closed
tomvanswam opened this issue Aug 11, 2020 · 3 comments · Fixed by #11
Closed

Wrong abbreviations #10

tomvanswam opened this issue Aug 11, 2020 · 3 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@tomvanswam
Copy link
Owner

Hi there,

Thx for this card, I like it a lot!

Something is still not ok with the direction abbreviations. With v0.0.4 and 13°, I get abbreviation N where it should be NNE. See attachment
compass card 1
with further details.

Originally posted by @andilge in #8 (comment)

@tomvanswam tomvanswam mentioned this issue Aug 11, 2020
@tomvanswam tomvanswam self-assigned this Aug 11, 2020
@tomvanswam tomvanswam added the bug Something isn't working label Aug 11, 2020
@andilge
Copy link

andilge commented Aug 11, 2020

just fyi, home assistant Integration "Blitzortung" for lightning detection reports negative degrees (no idea up until which value). compass card can handle the pin on the compass, but fails with the abbreviations and then falls back to default N. See another screenshot attached.
2020-08-11_16-47

I'm not sure if this should be fixed within Integration "Blitzortung", one should expect only positive values.

@andilge
Copy link

andilge commented Aug 11, 2020

set a comment in blitzortung integration on
mrk-its/homeassistant-blitzortung#9

tomvanswam added a commit that referenced this issue Aug 11, 2020
@tomvanswam
Copy link
Owner Author

I will fix the negative degrees issue as well

tomvanswam added a commit that referenced this issue Aug 11, 2020
@tomvanswam tomvanswam removed their assignment Aug 11, 2020
@tomvanswam tomvanswam linked a pull request Aug 11, 2020 that will close this issue
This was referenced Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants