Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design suggestions #14

Closed
rsnodgrass opened this issue Aug 13, 2020 · 5 comments · Fixed by #16 or #46
Closed

Design suggestions #14

rsnodgrass opened this issue Aug 13, 2020 · 5 comments · Fixed by #16 or #46
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rsnodgrass
Copy link

Thrilled that someone built a working compass!! I started to build a similar compass card a few weeks back, but didn't have time to dig into why it wasn't displaying properly.

A few suggestions:

  • I feel like the wind speed is the most important data—and actionable by the user—as opposed to the wind direction. I'd suggest allowing user specification of the larger data point in the ring, and have the direction smaller and somewhere else (after all the direction is already on the arrow on the ring).

  • Visually, I'd suggest adding a small N to the top of the ring to indicate North. Small detail, but ties this all together.

  • Here is a similar compass from Ambient Weather. I like that this can cleanly display optional data like maximum gust wind speed for the day.

image

@tomvanswam tomvanswam added the enhancement New feature or request label Aug 13, 2020
@tomvanswam
Copy link
Owner

tomvanswam commented Aug 13, 2020

I have to thank you, because I got the idea for the card while having a look at your windcompass repo.

They are all good suggestions, I already thought of the possibility to select a different type of indicator

  • arrow inwards (wind)
  • arrow outwards (e.g. lightning location see screenshots in Wrong abbreviations #10)
  • circle (e.g.for sun/moon)

And you're right, the direction is already made visible by the indicator, so it could be a lot less in your face and make space for other usefull info.

Consider this added to the wish/todo list

/offtopic, as the devcontainer in the repo is not working for me anymore, I cannot easily develop at this moment. Somehow the container is running, open ports for a develop home assistant instance, but the browser on my host throws a ERR_CONNECTION_REFUSED
When I get this fixed I can work on the wishlist again.

@tomvanswam tomvanswam self-assigned this Aug 13, 2020
tomvanswam added a commit that referenced this issue Aug 14, 2020
cleanup css bloat
change compass background to transparent
styling more inline with default cards
@tomvanswam tomvanswam linked a pull request Aug 14, 2020 that will close this issue
@tomvanswam tomvanswam reopened this Aug 14, 2020
@tomvanswam
Copy link
Owner

Not all imporvements done yet...

tomvanswam added a commit that referenced this issue Aug 15, 2020
Fix overflow issues on small cards
tomvanswam added a commit that referenced this issue Aug 15, 2020
Add optional north indicator #14
@kzim200
Copy link

kzim200 commented Aug 18, 2020

Thanks for the card!
A suggestion is that the arrow changes colors according to user-set wind speeds, like in bar-chart, and big number card.

Thanks again.

@tomvanswam
Copy link
Owner

Thanks for the card!
A suggestion is that the arrow changes colors according to user-set wind speeds, like in bar-chart, and big number card.

Thanks again.

Issue #12 covers this. As this is a bit more work, it will take a bit longer to implement.

@tomvanswam
Copy link
Owner

More design suggestions here.

@tomvanswam tomvanswam added this to the v0.5.0 milestone Sep 20, 2020
@tomvanswam tomvanswam mentioned this issue Nov 27, 2020
@tomvanswam tomvanswam linked a pull request Nov 27, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants