Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging two databases #13

Open
lskatz opened this issue Aug 18, 2020 · 2 comments
Open

Merging two databases #13

lskatz opened this issue Aug 18, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@lskatz
Copy link
Collaborator

lskatz commented Aug 18, 2020

Just a thought for a future version (and not now) but it might be kind of awesome if we could merge two databases. If it works, it could be a mechanism for users to update local databases without having to remake them.

@lskatz lskatz added the enhancement New feature or request label Aug 18, 2020
@lskatz lskatz added this to the backburner milestone Aug 18, 2020
@luizirber
Copy link

In sourmash we "avoided" the merging problem by allowing multiple DBs to be searched at once. For example, you can run sourmash search query.sig db1.lca.json.gz db2.sbt.zip sig3.sig sig4.sig and keep appending LCA, SBT or just plain signatures to the end of the command.

(this also led to other discussions about diff/patch databases, so I'm also interested in how the solution is going to work here =] )

@lskatz
Copy link
Collaborator Author

lskatz commented Aug 19, 2020

Thank you for the insights @luizirber! We have found that with our slow redundant hard drives, it's faster to make sure all or most of the database is in one sig file, but we might also find that we want to have separate files to save time on things like indexing. We will also have to consider how the sqlite database merges on top of the sig files. Bottom line though is that this conversation and the linked conversation will be a good reference for us in the future when we can address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants