Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track length for dump info command not correct for tracks that are longer than 60 minutes #15

Open
thomasmhofmann opened this issue Nov 4, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@thomasmhofmann
Copy link

thomasmhofmann commented Nov 4, 2020

C:\Downloads>teddy -m info e:\500304E0-1592653827-96-kbs-11-works
Failed to load JSON:
Error converting value {null} to type 'System.Int32'. Path '[330].no', line 5882, position 16.
[Mode: dump information]
Dump of e:\500304E0-1592653827-96-kbs-11-works (UID 11962738659215E0040350):
Header: AudioID 0x5EEDF803 (2020-06-20T11:50:27)
Header: Length 0x00000FFC [OK]
Header: Padding 0x00000FB7
Header: AudioLen 0x20070CF9 [OK]
Header: Checksum D958DB332F329A38FE82D46675EF898C3BF3BFAE [OK] [NO JSON INFO]
Header: Chapters
Track #1 08:41.70
Track #2 08:45.20
Track #3 06:32.40
Track #4 12:54.86
Track #5 07:56.10
Track #6 17:51.00
Track #7 58:11.53
Track #8 58:51.38
Track #9 57:22.71
Track #10 57:56.07
Track #11 04:22.02
Ogg: Segments 4319332 (min: 32 max: 225 per OggPage)
Ogg: net payload 529471604 byte
Ogg: granules total: 2071919615 (11:59:24.99 hh:mm:ss.ff)
Ogg: granules/page min: 15360 max: 108000 (320ms - 2250ms)

The bold values are actually the value + 60 minutes. Total time is correct.

@steve8x8
Copy link
Contributor

steve8x8 commented Jan 5, 2023

Would the following change to TonieAudio/TonieTools.cs:188 fix this?

-                                lengthString = (trackOffset - prevTime).ToString(@"mm\:ss\.ff");
+                                lengthString = (trackOffset - prevTime).ToString(@"hh\:mm\:ss\.ff");

@SciLor SciLor added the bug Something isn't working label Jan 5, 2023
steve8x8 added a commit to steve8x8/teddy that referenced this issue Jan 6, 2023
g3gg0 added a commit that referenced this issue Aug 29, 2023
Add hours field to track info, issue #15
@steve8x8
Copy link
Contributor

Fixed by #54?

@steve8x8
Copy link
Contributor

If there was a new build of Teddy / TeddyBench we might find out. Any volunteers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants