Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Program.cs #1

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Update Program.cs #1

merged 2 commits into from
Jun 15, 2020

Conversation

ThomasSmallert
Copy link
Contributor

titles is an array.

@ThomasSmallert
Update Program.cs
471843d 
titles is an array.
@g3gg0
Copy link
Collaborator

g3gg0 commented Mar 29, 2020

Hello ThomasSellert,

thanks for your support and your contribution.
When looking closer at the code, you are right that a length check is missing.
Unfortunately just checking for a non-zero length is not sufficient.

It should be more like "titles != null && titles.Length > chapter" which should cover the
null-assignment in the case there is no json entry and the length check which should have been
there as the input data is user generated.

Do you want to update your PR to catch both?

regards,
g3gg0

@ThomasSmallert
Update Program.cs
c974cc8 
Hello g3gg0,
Thank you very much. 
You're right. I have changed it at your suggestion. 
Greetings,
ThomasSmallert
@g3gg0 g3gg0 merged commit ccbf73e into toniebox-reverse-engineering:master Jun 15, 2020
@thomasmhofmann thomasmhofmann mentioned this pull request Nov 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThomasSmallert @g3gg0