Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI elements are not scaled properly #343

Open
Trass3r opened this issue Oct 11, 2019 · 7 comments
Open

GUI elements are not scaled properly #343

Trass3r opened this issue Oct 11, 2019 · 7 comments
Labels
easy Should be easy for new comers etc.

Comments

@Trass3r
Copy link
Contributor

Trass3r commented Oct 11, 2019

When using higher-resolution images:
screenshot

@tonihele tonihele added the easy Should be easy for new comers etc. label Oct 11, 2019
@tonihele
Copy link
Owner

Did you generate these by some machine learning solution? If so, can it handle the transparencies? Also we could generate the test data with the same lib then :)

@Trass3r
Copy link
Contributor Author

Trass3r commented Oct 12, 2019

I tested Gigapixel. With transparency you get color fringes.
Also tested some generated normal maps but couldn't see a difference.

@tonihele
Copy link
Owner

I used https://github.com/xinntao/ESRGAN awhile back. Otherwise I got very nice results, but it didn't support transparencies. Got amazing detail to Reaper (https://cdn.knightlab.com/libs/juxtapose/latest/embed/index.html?uid=db515096-1e79-11e9-9dba-0edaf8f81e27).

Normal maps... Yeah you need to be up close and personal with them. Also we are only currently using only ambient light. I guess that contributes to the fact that everything looks a bit flat. We have an experimental branch (https://github.com/tonihele/OpenKeeper/tree/experimental-light) with real lights that was used by a artist for creating custom graphics with normal maps. The branch hasn't been updated in awhile, but it still of course works to see the graphics.

@Trass3r
Copy link
Contributor Author

Trass3r commented Jan 25, 2022

I used https://github.com/xinntao/ESRGAN awhile back. Otherwise I got very nice results, but it didn't support transparencies.

Most don't. You end up having to upscale the alpha separately and then recombine.

Got amazing detail to Reaper (https://cdn.knightlab.com/libs/juxtapose/latest/embed/index.html?uid=db515096-1e79-11e9-9dba-0edaf8f81e27).

Btw there is no launcher script for the model viewer.

we are only currently using only ambient light. I guess that contributes to the fact that everything looks a bit flat.

Yes I noticed that as well. Of course normal maps don't make a difference without at least diffuse lighting.

We have an experimental branch (https://github.com/tonihele/OpenKeeper/tree/experimental-light) with real lights that was used by a artist for creating custom graphics with normal maps. The branch hasn't been updated in awhile, but it still of course works to see the graphics.

I rebased it but too much has changed in the code for it to just work: https://github.com/Trass3r/OpenKeeper/tree/experimental-light

@tonihele
Copy link
Owner

With IDE:
image

Or from CMD:
./gradlew --configure-on-demand -PrunClassName=toniarts.openkeeper.tools.modelviewer.ModelViewer -x check runSingle

@tonihele
Copy link
Owner

I rebased it but too much has changed in the code for it to just work: https://github.com/Trass3r/OpenKeeper/tree/experimental-light

Yeah, I think the code was before our huge restructure. I can try to bring it to life in few days. There wasn't huge changes that I made back then.

@Trass3r
Copy link
Contributor Author

Trass3r commented Jan 25, 2022

Yeah it should definitely improve the visuals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Should be easy for new comers etc.
Projects
None yet
Development

No branches or pull requests

2 participants