Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goto not working when jumping to the same file #38

Closed
x4lldux opened this issue Jan 15, 2015 · 1 comment
Closed

Goto not working when jumping to the same file #38

x4lldux opened this issue Jan 15, 2015 · 1 comment

Comments

@x4lldux
Copy link
Contributor

x4lldux commented Jan 15, 2015

When jumping to a function that is in current buffer nothing happens.
Removing save-excursion from alchemist-goto-definition-at-point solves the problem - I think it shouldn't be in a function which supposed to move the point.
@tonini
Copy link
Owner

tonini commented Jan 15, 2015

Thanks for reporting, I will push a fix asap. <3

X4lldux notifications@github.com schrieb am Do., 15. Jan. 2015 23:07:

When jumping to a function that is in current buffer nothing happens.
Removing save-excursion from alchemist-goto-definition-at-point solves
the problem - I think it shouldn't be in a function which supposed to move
the point.

—
Reply to this email directly or view it on GitHub
#38.

x4lldux added a commit to x4lldux/alchemist.el that referenced this issue Jan 16, 2015
@x4lldux
Fix tonini#38
46a07b2 
Functions main purpose is moving point and `save-excursion` should not be applied here.
@tonini tonini closed this as completed Jan 20, 2015
x4lldux added a commit to x4lldux/alchemist.el that referenced this issue Aug 23, 2015
@x4lldux
Revert "Fix tonini#38"
3bfd998 
This reverts commit 46a07b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@x4lldux @tonini