Keep the V flag on the 68030 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some experiments with BCD arithmetic corner cases I have noticed that the V flag isn't handled properly on the 030 -- it shouldn't be involved in the calculation (contrary to the 68000). I can't test how it performs on the 020, most likely the same, i.e.
xBCD_KEEPS_V_FLAGshould be changed to2after confirmation.Tested & implemented on Hatari's
cpu/gencpu.cand backported by hand, I hope I didn't miss anything. Tested on all possible combinations ofZ,Cand both byte operands (2 * 2 * 256 * 256 tests).