Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the list of requirements in setup.py #73

Merged
merged 1 commit into from Oct 29, 2018

Conversation

encukou
Copy link
Contributor

@encukou encukou commented Oct 12, 2018

Pip's internal API is unstable and might actually change more often
than the list of requirements.

Put the requirements in setup.py, and refer there from requirements.txt

Pip's internal API is unstable and might actually change more often
than the list of requirements.

Put the requirements in setup.py, and refer there from requirements.txt
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files          10       10           
  Lines        1683     1683           
=======================================
  Hits         1415     1415           
  Misses        268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1deef0e...91f40ec. Read the comment docs.

@tonioo
Copy link
Owner

tonioo commented Oct 29, 2018

@encukou Thank you.

@tonioo tonioo merged commit ef64ef3 into tonioo:master Oct 29, 2018
@encukou encukou deleted the setup-requirements branch October 29, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants