dockerfile: fix test-base-rhel #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tonistiigi
reviewed
May 29, 2024
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Jun 13, 2024
| if command -v dnf >/dev/null 2>/dev/null; then | ||
| dnf install -y bats vim | ||
| else | ||
| yum install -y bats vim |
There was a problem hiding this comment.
follow-up nit: would be good to make it so that the package list is not duplicated so multiple lines don't need to be changed for modifications and they can't accidentally diverge (at least until both use same package names). Eg. can put the arg0 to a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #157 (comment)
https://github.com/tonistiigi/xx/actions/runs/9254378665/job/25456054906?pr=157#step:6:289