Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better power/airline alignment in iTerm2? #131

Closed
landaire opened this issue Feb 9, 2016 · 7 comments
Closed

Better power/airline alignment in iTerm2? #131

landaire opened this issue Feb 9, 2016 · 7 comments
Labels

Comments

@landaire
Copy link

landaire commented Feb 9, 2016

I started using vim-airline recently and after tinkering with the vertical alignment and sizes with the font I finally got the > block on the left aligned pretty well but the < block on the right is not aligned as wanted.

Here's a picture of the issue
screen shot 2016-02-09 at 12 27 30

Is there any way to fix this? To achieve this I had to set my ASCII font to Fira Code Retina size 11, my non-ascii font to Fira Code Retina size 13 and adjust the vertical alignment to about 1.15:

screen shot 2016-02-09 at 12 30 41

@tonsky tonsky added the bug label Feb 15, 2016
@tonsky
Copy link
Owner

tonsky commented Feb 22, 2016

Looks like no, no easy way to fix it. Powerline is a hack, so expect it to behave like a hack

Related: powerline/fonts#31

There's just too many factors (different ways of calculating font metrics, different operating systems, different antialiasing technologies, different fonts) to reliably patch a font for every single combination of these factors. You can patch it manually in fontforge or ignore the issue until a fix is found

@tonsky tonsky closed this as completed Feb 22, 2016
@pencilcheck
Copy link

Hack has a long thread of correcting the arrow bit by bit. Reference: source-foundry/Hack#33

Whereas Fantasque Sans Mono has perfectly aligned arrow:
https://github.com/belluzj/fantasque-sans

If Fira Code can do the same, that would be really awesome!

@tonsky
Copy link
Owner

tonsky commented Apr 6, 2017

The problem is, you can fix it for one specific OS / terminal combination but it might still be wrong for all the others. There’s no reliable way to do this properly. E.g. this is how Fantasque looks for me (OS X, Terminal.app):

screen shot 2017-04-06 at 14 17 27

@pencilcheck
Copy link

True, but that doesn't mean there is no way we can't make it so the at least it is adjustable to look as close as aligned properly as close as possible. FiraCode right now doesn't seems to be able to can't make it look at least ok (without gap or able to align it close to the center) even by adjusting the spacing.

Fantasque font works fine almost out of box on iTerm2 though.

I also noticed that PragmataPro with powerline patch looks pretty good on Terminal.app out of box, it look fine after minor spacing adjustment on iTerm2.

Perhaps you should look into PragmataPro and see how they made it so it look good on both iterm2 and terminal

@pencilcheck
Copy link

And btw, here is another font that the arrow looks aligned on both terminal.app and iterm out of box.

https://github.com/be5invis/Iosevka

@tonsky
Copy link
Owner

tonsky commented Apr 6, 2017

I wouldn’t be so sure...

screen shot 2017-04-06 at 19 58 19

@pencilcheck
Copy link

Looks like that happen only in Terminal.app when you have font size smaller than 18.

It looks fine on iTerm
screen shot 2017-04-06 at 10 39 30 am

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
…endpoint

Support the latest_specs endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants