Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some reason, -> is not working in Atom. #63

Closed
ioquatix opened this issue Nov 1, 2015 · 9 comments
Closed

For some reason, -> is not working in Atom. #63

ioquatix opened this issue Nov 1, 2015 · 9 comments

Comments

@ioquatix
Copy link

ioquatix commented Nov 1, 2015

Any ideas what I'm doing wrong? '=>' is working fine.

@lbguilherme
Copy link

Try with plaintext (without a syntax highlighter).
Works fine for me.

@MadcapJake
Copy link

Also works for me. Did you add:

atom-text-editor {
  text-rendering: optimizeLegibility;
}

to your styles.less file?

@ioquatix
Copy link
Author

ioquatix commented Nov 6, 2015

Yes.

@MadcapJake
Copy link

Ok, while working on some language grammars, I discovered something that might be at the root of your problem: the ligatures only capture if the underlying html span element contains both characters to be ligaturized. Some language grammars fail to fully capture multi-char operators instead choosing to allow a big list of operator characters to capture them. This means that, to the editor, it's actually a - operator next to a > operator (in whatever language you are using). So, to determine if this is the issue, try another language file (maybe even a few), try just an empty plain text file, or try other ligatures (especially ones with characters that aren't operators). If that is the issue, then there is nothing that this project can do and you need to post an issue in the language's atom syntax highlighter repo.

@ioquatix
Copy link
Author

ioquatix commented Nov 6, 2015

@MadcapJake ah yeah it looks exactly like that.

@mamenama
Copy link

mamenama commented Nov 6, 2015

I added a commit to PR atom/language-ruby#113 which will address this issue (for Ruby at least). If there are other languages which need it, let me know and I can try to add it to them too (though I must admit I'm mostly familiar with Ruby grammar)

@ioquatix
Copy link
Author

ioquatix commented Nov 6, 2015

Awesome, I think I'll close this issue now since it's obviously not a problem with FiraCode but the Ruby syntax definition.

@pixelbreaker
Copy link

pixelbreaker commented Jul 23, 2017

I found that => wasn't working with language-jsx package, then I discovered language-babel which is a much better package anyway, so just switched to that.

@kalifg
Copy link

kalifg commented Feb 23, 2018

I can't seem to see any ligatures in php files, although I do see a limited set in javascript files

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
Create the CHANGELOG with a rake task to generate it automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants