New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon on item list #126

Closed
tontof opened this Issue Mar 22, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@tontof
Owner

tontof commented Mar 22, 2013

Add favicon on item list

@ali0une

This comment has been minimized.

Show comment
Hide comment
@ali0une

ali0une Mar 22, 2013

Contributor

i already though about it, i tried to code something but i wasn't able to get the $feed['htmlUrl'] (it seems like $item['via'] is the same value) and $feedHash from the file /kriss_feed/src/class/tpl/list_items.tpl.php
if i had those i could have called the grabFavicon($feed['htmlUrl'], $feedHash); function. :-/

Contributor

ali0une commented Mar 22, 2013

i already though about it, i tried to code something but i wasn't able to get the $feed['htmlUrl'] (it seems like $item['via'] is the same value) and $feedHash from the file /kriss_feed/src/class/tpl/list_items.tpl.php
if i had those i could have called the grabFavicon($feed['htmlUrl'], $feedHash); function. :-/

@tontof

This comment has been minimized.

Show comment
Hide comment
@tontof

tontof Mar 23, 2013

Owner

Yes I already think about that and it should be possible to use xmlUrl from item as feedHash correspond to MyTool::smallHash of xmlUrl. As favicon file corresponds to favicon-feedhash.ico it will not be that difficult.

Owner

tontof commented Mar 23, 2013

Yes I already think about that and it should be possible to use xmlUrl from item as feedHash correspond to MyTool::smallHash of xmlUrl. As favicon file corresponds to favicon-feedhash.ico it will not be that difficult.

@tontof

This comment has been minimized.

Show comment
Hide comment
@tontof

tontof Mar 25, 2013

Owner

I've done it
da99a40

Owner

tontof commented Mar 25, 2013

I've done it
da99a40

@tontof tontof closed this Mar 25, 2013

@ali0une

This comment has been minimized.

Show comment
Hide comment
@ali0une

ali0une Mar 25, 2013

Contributor

wonderful 👍

Contributor

ali0une commented Mar 25, 2013

wonderful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment