GVH5184 - Refactor probeset #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tighter / better aesthetic / easier to intuit what code is doing with bit/hex comparison. Lines 60-74 Before: 605 characters - Compiled Driver: 2616 After: 583 characters - Compiled Driver: 2535 - 3% reduction in size I have no idea how you would compare it from a computational efficiency perspective but should be slightly more efficient b/c the calculations/lookups for status, probetemp, and probeset are only performed once. probeset is declared with values set and then only 2 IF statements required instead of 3 to set the first two flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring - tighter / better aesthetic / easier to intuit what code is doing with bit/hex comparison.
Lines 60-78
Before: 605 characters - Compiled Driver: 2616
After: 583 characters - Compiled Driver: 2535 - 3% reduction in size
I have no idea how you would compare it from a computational efficiency perspective but should be slightly more efficient b/c the calculations/lookups for status, probetemp, and probeset are only performed once. probeset is declared with values set and then only 2 IF statements required instead of 3 to set the first two flags.
Tested on ESP32Solo1 with both live device and spoofer. All readings coming int MQTT and HA as expected.