Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVH5184 - Refactor probeset #18

Merged
merged 8 commits into from
Jan 11, 2022
Merged

Commits on Jan 8, 2022

  1. Update README.md

    ElksInNC committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    5fa457b View commit details
    Browse the repository at this point in the history
  2. Update README.md

    ElksInNC committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    1fd053f View commit details
    Browse the repository at this point in the history
  3. Initial discovery code

    ElksInNC committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    b59c850 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    758cd88 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Configuration menu
    Copy the full SHA
    74e5876 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Configuration menu
    Copy the full SHA
    f569e80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c90fd8a View commit details
    Browse the repository at this point in the history
  3. Refactored probeset section

    Tighter / better aesthetic / easier to intuit what code is doing with bit/hex comparison.
    Lines 60-74
    Before: 605 characters - Compiled Driver: 2616
    After: 583 characters - Compiled Driver: 2535 - 3% reduction in size
    
    I have no idea how you would compare it from a computational efficiency perspective but should be slightly more efficient b/c the calculations/lookups for status, probetemp, and probeset are only performed once. probeset is declared with values set and then only 2 IF statements required instead of 3 to set the first two flags.
    ElksInNC committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5a89566 View commit details
    Browse the repository at this point in the history