Add chunked-upload and support for audio/video processing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony612
requested changes
Jul 18, 2017
| case File.stat(local_file) do | ||
| {:ok, %{size: file_size, type: :regular}} -> | ||
| File.stream!(local_file, [], @default_block_size) | ||
| |> Stream.map(fn(blk) -> |
There was a problem hiding this comment.
How about extract this anonymous function to a function in a module?
There was a problem hiding this comment.
I think that anonymous function is explicit enough: A block |> chop |> upload. That does't deserve a independence function, and really hard to name it 😜
lib/qiniu/chunk_upload.ex
Outdated
| end | ||
|
|
||
| def send_chunk([], _offset, ctx, _uptoken, _host), do: ctx | ||
|
|
There was a problem hiding this comment.
I prefer to delete this blank line for this kind of function.
lib/qiniu/fop/av.ex
Outdated
| alias Qiniu.HTTP | ||
|
|
||
| def avthumb(bucket_name, key, opts \\ []) do | ||
| query_opts = opts |> Keyword.take([:"notifyURL", :pipeline]) |> Enum.into(%{}) |
There was a problem hiding this comment.
Why not use : notifyURL directly? And the one on next line.
lib/qiniu/fop/av.ex
Outdated
| fops: trans_fops(fog_opts), | ||
| } | ||
| |> Map.merge(query_opts) | ||
| ) |
There was a problem hiding this comment.
It seems that it can be changed to?
%{...}
|> Map.merge(query_opts)
|> URI.encode_query
Repository owner
deleted a comment from
coveralls
Jul 18, 2017
Repository owner
deleted a comment from
coveralls
Jul 18, 2017
Repository owner
deleted a comment from
coveralls
Jul 18, 2017
Repository owner
deleted a comment from
coveralls
Jul 18, 2017
Repository owner
deleted a comment from
coveralls
Jul 18, 2017
- reduce blank lines for single-line `def`s - style: direct use `:notifyURL` - pipline funs calling
|
merged. And 0.4.0 is published with this feature. Thank you! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qiniu Chunked-Upload
Qiniu AV Processing