Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid * activating extension #290

Merged

Conversation

joyceerhl
Copy link
Contributor

From the README it looks like the primary functionality that this extension exposes is via commands. This PR should resolve #75

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #290 (c611b9e) into master (60ba3c7) will increase coverage by 2.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage    8.35%   10.53%   +2.17%     
==========================================
  Files           3        5       +2     
  Lines         634      655      +21     
  Branches       90       92       +2     
==========================================
+ Hits           53       69      +16     
- Misses        581      586       +5     
Impacted Files Coverage Δ
src/common/names.ts 78.57% <0.00%> (ø)
src/common/types.ts 71.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney
Copy link
Owner

Thanks for the PR!

Sadly this didn't work when the panel is used in the View model under the explorer panel, I tried onView:Explorer and onView:petsView but none of them would re-activate the extension when reloading VS Code so I've put onStartupFinished in which solves the problem.

@tonybaloney tonybaloney merged commit 1065478 into tonybaloney:master Oct 26, 2022
@joyceerhl
Copy link
Contributor Author

Thank you! FWIW, onView:petsView should suffice to reactivate an extension contributing a view to explorer on reload, and I just checked that this works as expected with the Calico Colors extension sample: https://github.com/microsoft/vscode-extension-samples/blob/fdd3bb95ce8e38ffe58fc9158797239fdf5017f1/webview-view-sample/package.json#L22-L37

tonybaloney added a commit that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activation event is too broad
3 participants