Fix creating graphs for directories in Windows (fix #190) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 95.25% 95.26%
=======================================
Files 23 23
Lines 1222 1224 +2
Branches 275 275
=======================================
+ Hits 1164 1166 +2
Misses 33 33
Partials 25 25
|
tonybaloney
reviewed
Jul 10, 2023
Merged
tonybaloney
approved these changes
Jul 12, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, graphs for directories don't work due to non-matching path separators in
rev.revision.tracked_filesandrev.get. This trivial patch fixes it, and doesn't break graph creation in Linux (tested on WSL).Fixes #190.