Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff CI checks #195

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

devdanzin
Copy link
Collaborator

Raise ruff's max-args, max-branches and max-statements because CI checks are failing (e.g. in #191) due to ruff finding the following errors:

src\wily\__main__.py:263:5: PLR0913 Too many arguments to function call (9 > 8)
    |
261 | )
262 | @click.pass_context
263 | def report(
264 |     ctx, file, metrics, number, message, format, console_format, output, changes
265 | ):
    |

src\wily\commands\report.py:24:5: PLR0913 Too many arguments to function call (9 > 8)
   |
24 | def report(
   |     ^^^^^^ PLR0913
25 |     config,
26 |     path,
   |

src\wily\commands\report.py:24:5: PLR0912 Too many branches (32 > 31)
   |
24 | def report(
   |     ^^^^^^ PLR0912
25 |     config,
26 |     path,
   |

src\wily\commands\report.py:24:5: PLR0915 Too many statements (94 > 91)
   |
24 | def report(
   |     ^^^^^^ PLR0915
25 |     config,
26 |     path,
   |

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #195 (44fd10c) into master (70ce4da) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   95.23%   95.25%   +0.01%     
==========================================
  Files          23       23              
  Lines        1217     1222       +5     
  Branches      273      275       +2     
==========================================
+ Hits         1159     1164       +5     
  Misses         33       33              
  Partials       25       25              
Impacted Files Coverage Δ
src/wily/__main__.py 95.53% <100.00%> (+0.02%) ⬆️
src/wily/commands/report.py 97.08% <100.00%> (+0.11%) ⬆️

@tonybaloney tonybaloney merged commit 6db8374 into tonybaloney:master Jul 10, 2023
19 checks passed
@devdanzin devdanzin deleted the fix_ruff_checks branch July 10, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants