Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Nuke): Ability to lock instead of remove #163

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

Venefilyn
Copy link
Member

@Venefilyn Venefilyn commented Oct 10, 2019

Fixes #94

Does not have a config entry, instead always defaults to remove. If we want to make this have a default option in settings we should implement a radio config type

image

@creesch
Copy link
Member

creesch commented Oct 10, 2019

settings we should implement a radio config type

Not really, we can simply use the existing selector setting type, example here

@Venefilyn
Copy link
Member Author

I'll add that then and let you when know PR is ready :)

@creesch creesch added this to the v5.2 milestone Oct 10, 2019
@Venefilyn
Copy link
Member Author

Venefilyn commented Oct 10, 2019

@creesch config added. The dot does not exist in the config, disregard that
image

@creesch creesch merged commit 79d0da3 into toolbox-team:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comment lock functionality to more toolbox functions
2 participants