Add graphics acceleration indicator to Debug widget #44
Conversation
|
If acceleration is working in 99.9% of computers then we should remove this indicator from the FPS widget - to save people wondering what it is. Also, the network graph suggests I'm still not doing this branch thing properly. I think it's because I forgot to pull to my computer and checkout master before creating the next branch. Let me know if it's messed up from your end. I'll get it right next time ;) |
|
I will look into this now. I think it is a good idea to add it to the debug widget. The numbers in there are generally confusing, so one more won't hurt :-P Regarding the branching: You already figured it out. Before you create a branch you need to pull and checkout master. I will try to fix it for the messed up branches by rebaseing and force pushing. This might cause problems on your end, however these problems should vanish as soon as the pull request is merged. |
* used only one instance of the counter class * passed counter to the relevant parts via dependency injection * removed counter from widget and fragment drawer since it does not really belong there * removed dot from fps widget to reduce users confusion
stefandollase
force-pushed
the
acceleration-indicator
branch
from
6b50553
to
e9266d9
Compare
|
I removed the dot from the FPS widget. This will hopefully reduce the confusion. Other than that I do like the idea to include it as a debug information. This should help us to sort out the issue with the unaccelerated graphics if it is an issue for many users. |
stefandollase
changed the title
Add graphics acceleration indicator to Debug widget
Might be a bit of an overkill, since I suspect graphics are accelerated for nearly everyone, but I'd like to keep an eye on it during development.
There's now a dot on the FPS widget that's green if everything's accelerated, and blue if it's not. The Debug widget lists the value as a percentage.