Remove stop funcion #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supertassu
reviewed
Apr 10, 2024
| ) | ||
| result_dictionary = ast.literal_eval(query_run.extra_info) | ||
| if "connection_id" in result_dictionary: | ||
| g.replica.connection = db_of_process |
There was a problem hiding this comment.
fwiw, this seems obviously wrong - db_of_process is a parameter with the database name, so it doesn't have a .cursor() method that the next line uses
There was a problem hiding this comment.
it's fine. .connection = on this line invokes the setter in the Replica class. On the next line, it's a getter which gives the underlying pymysql connection which does have a .cursor() method.
Does not work with threads on separate instances Bug: T362213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not work with threads on separate instances
Bug: T362213